[PATCH] Remember pre-existing trip expansion state when autogrouping

Linus Torvalds torvalds at linux-foundation.org
Tue Feb 19 13:51:36 PST 2013


On Tue, Feb 19, 2013 at 1:20 PM, Dirk Hohndel <dirk at hohndel.org> wrote:
> Linus Torvalds <torvalds at linux-foundation.org> writes:
>>
>> We should probably aim to do the whole "restore tree state" in
>> dive_list_update_dives() unconditionally. Right now, almost all of the
>> callers do it, and the two remaining cases (main.c and webservice.c
>> should probably do it too.
>
> I just noticed that webservice has them all collapse which is really
> strange... the same dive stays selected, but it's no longer visible.

Yup.

Anyway, I'll send a patch for your perusal shortly. It seems to work
for me, but people should check it with all the normal operations (and
switching between sort orders etc).

              Linus


More information about the subsurface mailing list