[PATCH 1/2] Change divelogs.de export file suffix from .ZIP to .DLD

Miika Turkia miika.turkia at gmail.com
Wed Feb 20 19:19:06 PST 2013

On Thu, Feb 21, 2013 at 1:47 AM, Henrik Brautaset Aronsen
<subsurface at henrik.synth.no> wrote:
> Dirk Hohndel wrote:
> But that makes no sense to the user. Is that ever exposed anywhere? I
> guess just in errors / warning... so we should be ok
> Yup, it's just used in the error message in parse_xml_buffer.  Not an ideal
> solution, but XML parsing inside an SDE or DLD should "never" fail.  Famous
> last words :)

Here is one suggestion for a clearer error message. Display the file
name instead of text 'ZIP file' on the error. This way it should be
very clear failed to parse. And we don't have to worry about the file
extension either.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Display-the-filename-on-error-message.patch
Type: application/octet-stream
Size: 1349 bytes
Desc: not available
URL: <http://lists.hohndel.org/pipermail/subsurface/attachments/20130221/32dca174/attachment.obj>

More information about the subsurface mailing list