DC ceiling not shown

[Linus Torvalds]

On Fri, Feb 22, 2013 at 8:48 AM, Miika Turkia <miika.turkia at gmail.com> wrote:
> On Fri, Feb 22, 2013 at 9:05 PM, Robert C. Helling <helling at lmu.de> wrote:
>> Hi,
>>
>> here is an .xml file that came into subsurface via import from jdivelog. As
>> you can see it has deco information coming originally from the computer
>> (which probably was n OSTC but I am not sure, this is not my file). This
>> does dont show the dc ceiling. I don't know if that is a problem with the
>> parser or the display.
>
> I do not see anything wrong in the XML file when comparing to
> http://trac.hohndel.org/raw-attachment/ticket/38/ostc.jlb.bz2 (after
> reading this jlb with subsurface and saving one dive with deco info in
> subsurface format). Even though the dives seem the same, Subsurface
> displays the ceiling with the ostc.jlb and not with your sample.

The dive has NDL=1min in the XML file, and it apparently never gets
cleared. So the samples look like this:

  ...
  <sample time='6:00 min' depth='49.82 m' temp='6.1 C' ndl='2:00 min' />
  <sample time='6:10 min' depth='51.0 m' />
  <sample time='6:20 min' depth='51.61 m' />
  <sample time='6:30 min' depth='52.89 m' />
  <sample time='6:40 min' depth='53.14 m' />
  <sample time='6:50 min' depth='53.82 m' />
  <sample time='7:00 min' depth='54.54 m' temp='6.0 C' ndl='1:00 min' />
  <sample time='7:10 min' depth='54.96 m' />
  <sample time='7:20 min' depth='55.09 m' />
  <sample time='7:30 min' depth='55.13 m' />
  <sample time='7:40 min' depth='54.96 m' />
  <sample time='7:50 min' depth='55.07 m' />
  <sample time='8:00 min' depth='54.89 m' temp='5.8 C' stoptime='1:00
min' stopdepth='12.0 m' />
  <sample time='8:10 min' depth='54.91 m' />
  <sample time='8:20 min' depth='54.84 m' />
  <sample time='8:30 min' depth='55.05 m' />
  <sample time='8:40 min' depth='55.18 m' />
  <sample time='8:50 min' depth='55.15 m' />
  <sample time='9:00 min' depth='55.12 m' temp='5.7 C' stopdepth='15.0 m' />
  ...

and when the dive goes into deco at the 8:00 mark, subsurface still
remembers that "ndl='1:00 min'". And because there is a NDL time, we
then don't print the ceiling, because we consider the stop to be just
a safety stop, not a deco ceiling.

Now, we should be able to figure this out, because we do have:

  <event time='8:00 min' name='deco' />
  <event time='31:40 min' name='PPO2 HIGH' />
  <event time='0:00 min' value='21' name='gaschange' />
  <event time='30:50 min' value='50' name='gaschange' />

so that event at time 8:00 should give us a big hint that we should
clear NDL. But we don't match that up with the samples at XML parse
time, and Dirk at some point confused things further with the whole
"in_deco" flag that is not matched against ndl *either*.

In short, we're confused. We have three different ways of showing
deco: deco events, the in_deco flag, and ndl. And none of them talk to
each other.

You can force it right now by adding "ndl='0:00 min'" to that sample
at time 8:00, but we really should do better.

                          Linus