Editing TIme/Date

Dirk Hohndel dirk at hohndel.org
Sun Feb 24 08:50:41 PST 2013


"Lubomir I. Ivanov" <neolit123 at gmail.com> writes:
>>> >> >
>>> >> > I have received two independent requests asking how to edit the date/time of a dive. It seems this is currently not possible through the GUI, only editing the xml. Am I right?
>>> >>
>>> >> Select a dive from the divelist. Right-click and select 'Edit dive
>>> >> date/time' from the popup menu.
>>> >
>>> > Just noticed while testing that, the seconds part of the 'time' is
>>> > presented rounded down to "even" '0' or '5'.  Do people see that too?
>>>
>>> Not sure what you mean. I thought we only show HH:MM and no seconds at
>>> all... where do we show seconds rounded down?
>>
>> Sorry, it's the minutes part.  If the time shown in the list is for
>> example 15:29, the edit will display it as 15:25.
>
> i've sent a patch for that:
> [PATCH] Remove rounding of the value for minutes when editing dive date/time
> but dirk may have an explanation why the rounding occurs.
> i don't have much of an idea...as per usual. :-)

I think this was Linus' code originally - and the widget was used to
enter the start time of manually added dives. So I guess it made some
limited sense to round the times... but even that's debatable.

/D


More information about the subsurface mailing list