[PATCH 2/2] Correctly calculate SAC rate in the presense of surface events

Dirk Hohndel dirk at hohndel.org
Sun Feb 24 11:10:38 PST 2013


Linus Torvalds <torvalds at linux-foundation.org> writes:
>
> Ok, the code makes sense and gets the right answer for the new test-case. 

Thanks for that, especially the test case

> What do people think we should show for the dive duration field in the 
> dive list for that last sac-test dive? We spent 30 minutes on the dive 
> end-to-end, but only 25 minutes actually under water. Is it a 30-minute 
> dive, or a 25-minute one? Is the average depth 10m (which is what we use 
> for SAC calculations) or 8.33m (which is the average over the whole 30 
> minutes)?

I think it's a 25 minute dive with an average depth of 10m.

/D


More information about the subsurface mailing list