[PATCH] Fix GPS import from divinglog

Linus Torvalds torvalds at linux-foundation.org
Mon Feb 25 07:17:24 PST 2013


I'm not convinced xslt is any better. The language is so unreadable as to
result in it being unmaintainable. I actually tried to write a stupid
script to add ask the crazy XML syntax on top of something more readable,
but I gave up.

So the whole notion of having xml transformations for foreign formats is a
nice idea, but it is destroyed my the horrible mess that is xslt.

                Linus
On Feb 25, 2013 7:04 AM, "Dirk Hohndel" <dirk at hohndel.org> wrote:

>
> On Feb 24, 2013, at 11:20 PM, Miika Turkia wrote:
>
> > Ticket #63 - divinglog 5.08 import issues
> > This patch will include the GPS coordinates from divinglog.
> >
> > Signed-off-by: Miika Turkia <miika.turkia at gmail.com>
> > ---
> > I suppose the question really is whether we want to keep adding the XML
> > tag names here or just do the conversion to Subsurface format with XSLT.
>
> As I said earlier, I'd much rather see us tighten up our parser
> and do these conversions in XSLT.
>
> I want to cut 3.0.1 today. If you can do this in XSLT without too much
> trouble I'll wait for that, otherwise I'll take this patch.
>
> Please let me know
>
> For 3.1 I would like us to really move all these things into XSLT and
> have a much cleaner parser.
>
> /D
>
>
> _______________________________________________
> subsurface mailing list
> subsurface at hohndel.org
> http://lists.hohndel.org/cgi-bin/mailman/listinfo/subsurface
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.hohndel.org/pipermail/subsurface/attachments/20130225/4faffab3/attachment-0001.html>


More information about the subsurface mailing list