[PATCH] Fix GPS import from divinglog

Dirk Hohndel dirk at hohndel.org
Mon Feb 25 08:00:29 PST 2013


Miika Turkia <miika.turkia at gmail.com> writes:

> On Mon, Feb 25, 2013 at 5:04 PM, Dirk Hohndel <dirk at hohndel.org> wrote:
>>
>> On Feb 24, 2013, at 11:20 PM, Miika Turkia wrote:
>>
>>> Ticket #63 - divinglog 5.08 import issues
>>> This patch will include the GPS coordinates from divinglog.
>>>
>>> Signed-off-by: Miika Turkia <miika.turkia at gmail.com>
>>> ---
>>> I suppose the question really is whether we want to keep adding the XML
>>> tag names here or just do the conversion to Subsurface format with XSLT.
>>
>> As I said earlier, I'd much rather see us tighten up our parser
>> and do these conversions in XSLT.
>>
>> I want to cut 3.0.1 today. If you can do this in XSLT without too much
>> trouble I'll wait for that, otherwise I'll take this patch.
>>
>> Please let me know
>
> I won't be able to write the XSLT today...thus this patch.

No problem. Applied and pushed.

>> For 3.1 I would like us to really move all these things into XSLT and
>> have a much cleaner parser.
>
> That should be fine with me.

Good. And I will put on my thinking cap and try to learn that
monstrosity of a language so I can help maintain these files.

Urgs.

/D


More information about the subsurface mailing list