[PATCH] Generate/update a version.h header file.
Dirk Hohndel
dirk at hohndel.org
Tue Feb 26 12:07:12 PST 2013
Bearsh <me at bearsh.org> writes:
>>> So, are you happy with the patch, after considering my comment:
>>
>> It does create the version.h file. But the thing that failed for me in
>> my attempts appears to fail with this as well...
>>
>> I add a #include "version.h" to gtk-gui.c
>>
>> I commit something to git. It updates the version. But gtk-gui.o is not
>> rebuilt :-(
>>
>> So I wonder if this is an issue with the version of make that I'm using...
>> .dep/gtk-gui.o.dep clealy lists version.h and version.h is indeed newer
>> than gtk-gui.o
>>
>> If I then do make -d to see what it considers it turns out that it never
>> considers whetner to rebuild gtk-gui.o based on version.h. So somehow
>> the new target breaks the dependency magic that Linus introduced.
>>
>> And that's easily proven by running 'make subsurface' in which case it
>> does indeed rebuild gtk-gui.o and then subsurface...
>
> for me it just updated the version.h file after calling make. subsequent
> calling ended up doing 'nothing' as it stopped once the tho versions
> (from git and from version.h) matched
>
> adding:
> all: gen_version_file $(NAME)
> to the makefile solved the issue, it also rebuild gtk-gui.c once I
> change the version...
It does? Is there a specific spot where I need to add this? Because when
I just tried that it didn't work :-(
Can you send a SOB patch that I can try?
/D
More information about the subsurface
mailing list