Fwd: [Subsurface-trac] [Subsurface] #73: description not escaped - brakes xml

Dirk Hohndel dirk at hohndel.org
Wed Feb 27 06:58:52 PST 2013


I know that we used to do that. We have all the routines to escape both attributes and regular content in XML. I wonder why we don't call that for the cylinder description attribute…

/D

Begin forwarded message:

> From: "Subsurface Bug Tracking System" <trac at hohndel.org>
> Subject: [Subsurface-trac] [Subsurface] #73: description not escaped - brakes xml
> Date: February 27, 2013 12:06:58 AM PST
> Cc: subsurface-trac at hohndel.org
> Reply-To: trac at hohndel.org
> 
> #73: description not escaped - brakes xml
> -------------------------------------+-------------------------------------
>                                            Reporter:|      Owner:  Subsurface Team
>  grischa.toedt@…                    |     Status:  new
>                                                Type:|  Component:  Other
>  defect                             |   Keywords:
>                                            Priority:|
>  major                              |
>                                             Version:|
>  3.0.1                              |
> Plattform (please give specifics in  |
>  the ticket text):  Mac             |
> -------------------------------------+-------------------------------------
> Steps to reproduce:
> 
> - open subsurface with your dives
> - add a new cylinder with description "twin 8's"
> - save & close
> - reopen subsurface > no dive will be displayed
> - the xml is broken now
> 
> Reason:
> Subsurface doesn't escape single quotes
> the entry in the xml will be <cylinder description='twin 8's' /> which is
> broken
> 
> Fix:
> escape single quotes before writing out the xml
> 
> This affects windos and mac, didnt test on linux but assume its the same
> 
> -- 
> Ticket URL: <http://trac.hohndel.org/ticket/73>
> Subsurface <http://subsurface.hohndel.org>
> Subsurface Dive Log
> _______________________________________________
> Subsurface-trac mailing list
> Subsurface-trac at hohndel.org
> http://lists.hohndel.org/cgi-bin/mailman/listinfo/subsurface-trac

-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 4130 bytes
Desc: not available
URL: <http://lists.hohndel.org/pipermail/subsurface/attachments/20130227/456f0665/attachment.bin>


More information about the subsurface mailing list