keyboard handling change
dirk at hohndel.org
Tue Jan 1 13:07:11 PST 2013
Miika Turkia <miika.turkia at gmail.com> writes:
> On Tue, Jan 1, 2013 at 9:49 PM, Linus Torvalds
> <torvalds at linux-foundation.org> wrote:
>> On Tue, Jan 1, 2013 at 10:38 AM, Dirk Hohndel <dirk at hohndel.org> wrote:
>>> Please give it a try and see if you can break it.
>> Works for me, but I'd suggest this additional patch to actually keep
>> the selected dive visible in the divelist.
> Seems to be working. However, when changing tabs e.g. from Dive Notes
> to Equipment, the highlighted row changes to gray (from brown) on my
> coloring. Thus it is hard to see which line is currently selected.
Yes - that's because the focus moves away.
> My intuition would expand or collapse the dive trips with left and
> right arrows as most other apps do with similar hierarchies... Not
> that I would have any better suggestions for changing the shown DC.
And I don't want a keyboard shortcut for expand and collapse - they mess
with gtk's notion of what is selected and we already spend quite a bit
of code on working around that mess...
More information about the subsurface