dive planner fixes [was: Re: source code may be getting a bit intimidating]

Dirk Hohndel dirk at hohndel.org
Mon Jan 7 13:43:08 PST 2013

Linus Torvalds <torvalds at linux-foundation.org> writes:

> Hmm. Playing around with it, I eventually get a lockup. It seems to be
> the same tissue-limit thing as before, though, and not really related
> to the planning itself. Although re-planning (by editing fields) does
> seem to be involved, but it's probably simply that the bug requires
> some special deco history or something.

I'll build in a bailout in that stupid loop until we have a rewrite.

> And yeah, "cancel" doesn't work right. I tried just deleting the last
> dive, and that caused a SIGSEGV. I think that was because the code
> tried to free() the dive computer model (it's set up a constant
> string),

Oops. I'll fix that.

> but I might be completely wrong about that - there might be
> something more fundamental going wrong.

I'm sure there's still a lot going fundamentally wrong. I'll wait for
your previous patch to be signed-off and added to the code and then
implement the correct cancel behavior.


More information about the subsurface mailing list