Improve dive trip sort comparison function

Linus Torvalds torvalds at linux-foundation.org
Mon Jan 7 14:12:07 PST 2013


We do want to compare "loose" dives too, but we need to be a bit
careful, and always use the trip date as the primary sort key for any
dives that are not in the same trip.

Reported-and-tested-by: Miika Turkia <miika.turkia at gmail.com>
Signed-off-by: Linus Torvalds <torvalds at linux-foundation.org>
---

On Mon, Jan 7, 2013 at 1:54 PM, Dirk Hohndel <dirk at hohndel.org> wrote:
>
> I just pushed a rather crude 'fix' for this. It doesn't address the
> underlying issue, but it at least bails out from the infinite loop and
> prints a warning instead.
>
> It's a hack, but it should allow you to test this patch of yours (and
> send it with commit message / SOB)
>
> /D

Ok, aside from the really funky deco coloring which is an independent
issue, this seems to work fine when loading both your and my dive
trips ;)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: patch.diff
Type: application/octet-stream
Size: 808 bytes
Desc: not available
URL: <http://lists.hohndel.org/pipermail/subsurface/attachments/20130107/6eb93f54/attachment.obj>


More information about the subsurface mailing list