crash with master when plotting the profile
dirk at hohndel.org
Tue Jan 8 14:27:53 PST 2013
Linus Torvalds <torvalds at linux-foundation.org> writes:
> On Mon, Jan 7, 2013 at 4:24 PM, Dirk Hohndel <dirk at hohndel.org> wrote:
>> I've done that. I now see another issue. If I start with one gas and
>> switch to another, the plan always appears to have a gas switch back to
>> the original first gas right after the end of my waypoints (i.e., right
>> were Subsurface starts developing the deco plan).
>> I haven't looked at this at all but just wanted to report it in case it
>> rings a bell
> I did report it in the other thread. It's the dive planning itself.
> It's confused, and uses things like "sample->sensor" to decide which
> cylinder to use etc. So it passes in bogus gases to
> plan_add_segment(). See the "plan()" function.
> I have *not* touched the actual dive planning itself. Any gases it
> makes up should *not* depend on some random sample->sensor, they
> should probably simply be looked up by pO2 value in the
> dive->cylinder array based on min/max depth of the segment. We will
> have populated the cylinder choices when we did the original dive
> plan, so we do have that information available (well, we *could* have
> it available - by having things like waypoints without depth or time,
> just gas information).
> It doesn't look impossible, but as mentioned, I haven't actually
> wanted to change the planning itself.
So this should be all better now. Please try with the latest changes.
More information about the subsurface