[PATCH 0/2] Clean up some of the dive computer nickname code
miika.turkia at gmail.com
Wed Jan 9 20:56:29 PST 2013
On Thu, Jan 10, 2013 at 2:43 AM, Dirk Hohndel <dirk at hohndel.org> wrote:
> Linus Torvalds <torvalds at linux-foundation.org> writes:
>> On Wed, Jan 9, 2013 at 4:30 PM, Linus Torvalds
>> <torvalds at linux-foundation.org> wrote:
>>> I guess I'm ok with it being merged, because the result is fine, and
>>> the Suunto hack is pretty isolated and not too disgusting. So go ahead
>>> and add a sign-off.
>> Oh, you should probably check that it works with your suunto too. I
>> may have two different suuntos, but they are both the same "vyper2"
>> back-end, so they are actually fairly similar. I *suspect* this is a
>> generic suunto format, but still..
>> The way the code works, you don't even have to download any actual new
>> dives: you just need to connect, see that the dive already exists, and
>> then do a ^S to save the end result. The divecomputer serial number
>> should have been picked up by then already, and automatically added
>> and saved to the xml file.
> I applied and pushed this. I think we have quite a few Suunto owners on
> this list (I dropped the libdivecomputer-devel list)... I'd appreciate
> if you could test this and report back that Linus' hack is right (and
> provide more data where it isn't)
Suunto Stinger and Suunto D4 give the correct serial number.
More information about the subsurface