[PATCH] gtk-gui.c: Move the download dialog related code to a new file

Lubomir I. Ivanov neolit123 at gmail.com
Thu Jan 10 11:02:33 PST 2013

On 10 January 2013 19:36, Dirk Hohndel <dirk at hohndel.org> wrote:

> Sorry it took me so long to get back to you...

> "Lubomir I. Ivanov" <neolit123 at gmail.com> writes:
> >
> > i've added a new file callbacks-gtk.h (naming scheme from display-gtk.h).
> > but i've kept the SCREEN_ prefix for the two macros, since this file can
> be used
> > by other dialogs in the future - e.g. a similar macro from print.c can
> > be moved here.
> I really dislike the SCREEN_ prefix.
> Also, the patch seems to have DOS line ends for the new files...
no idea how the DOS EOLs came around...
both issues should be fixed (attachment).

> But overall I think this is a good idea!
> Would you like to take another stab at it?
> > yeah, i also see potential for the nickname code to be moved to
> > nicknames.c, given we have the UI.
> > perhaps both the "backend" + UI.
> Well, Linus moved some of that code around already.
> Amit is working on the nickname edit UI and had played with putting that
> in its own file but it just wasn't enough code. Maybe it can now go into
> the device.c file to be with the related backend code...
perhaps it could..it also depends if device.c will grow in the future.
the example code for the dialog was around 150+ LOC with incomplete
gtk-gui.c still has set_dc_nickname(), remember_dc(), etc., which will
contribute another 200 LOC or so to a eventual nickname.c.
i would personally have it in a separate file, but do as you see fit, i

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.hohndel.org/pipermail/subsurface/attachments/20130110/8f614c49/attachment-0001.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-gtk-gui.c-Move-the-download-dialog-related-code-to-a.patch
Type: application/octet-stream
Size: 38864 bytes
Desc: not available
URL: <http://lists.hohndel.org/pipermail/subsurface/attachments/20130110/8f614c49/attachment-0001.obj>

More information about the subsurface mailing list