[PATCH] gtk-gui.c: Move the download dialog related code to a new file

[Linus Torvalds]

On Thu, Jan 10, 2013 at 12:06 PM, Dirk Hohndel <dirk at hohndel.org> wrote:
>
> The problem is that while you are a user of Subsurface I don't think you
> are the typical user. Most people will use Subsurface on one system with
> one (or a few) local XML files on that system.

That argument makes no sense.

If you only use a single machine, and a single xml file, then saving
stuff in the xml file has exactly the same semantics as using the
system config.

Normal users wouldn't use multiple xml files anyway, unless they have
multiple different things they track - in which case they may well
have multiple different configurations too. Imagine if your wife did
scuba diving too, and you tracked her dives. The system config file
actually contains things that are *personal*, like the tech dive
settings (which may not make sense for another diver).

So using the system config has no upsides. Not for "normal" users. And
certainly not for me.

And it's confusing as hell. There are various hidden config options
that you can't easily see.

IMNSHO, the *only* option that makes sense as a "system option" is the
"default_filename" thing. Everything else is simply wrong, because

 (a) you want to move your settings around with your dives

 (b) they are personal issues anyway, and if you track multiple people
it doesn't even necessarily make sense to have the same options (like
the deco GFlow/high things, which are really about personal
preferences, I'd argue)

I realize that we did it the way we did for historical reasons. But
they are historical, and they are wrong.

             Linus