[PATCH] gtk-gui.c: Move the download dialog related code to a new file

[Linus Torvalds]

On Thu, Jan 10, 2013 at 12:46 PM, Dirk Hohndel <dirk at hohndel.org> wrote:
>
> But you are completely missing the point that I made elsewhere in my
> email. It is entirely viable that a user has multiple divecomputers and
> wants to track them in separate files. So now she has to redo her
> settings for each file?

I'm not "missing" it. I'm "dismissing" it, because it's pointless.

Here's the big question: "So f*cking what?"

So you have to set some settings once per dive computer, *if* you use
subsurface in a strange and pointless way.

Is that an argument? Really?

It would have been an argument back when we didn't support multiple
dive computers well. But it just isn't any more.

Now, the biggest reason to use multiple XML files is because of
multiple people. In which case per-xml-file settings are the correct
thing to do.

> How about she wants to open a file from her dive buddy. That moron might
> prefer to see dives with pO2 values and with depth in ft - but she
> almost certainly wants to see what she is familiar with. Sane SI units
> and no silly other graphs that provide no information to her.

I'm ok with making the units be in the system config file, although I
would actually suggest we should use LC_MEASUREMENT as the default,
which would make most people not even set it at all.

> BTW: your argument is remarkably similar to the one made by the Gnome 3
> designers. "Use it as we say you want to use it, or you are not our
> target audience".

No. Your arguments are for odd use-cases, and are less flexible.

>> And it's confusing as hell. There are various hidden config options
>> that you can't easily see.
>
> There are? Interesting. The only confusion that I can see right now is
> that early data files have no divecomputer. Then a divecomputer without
> DeviceId. And then the current file format. But those are the growing
> pains of software that keeps being developed.

The confusion is about things like GFlow/high being hidden system
settings that you're not even thinking about, and that no sane people
remembers. They are easy to set, and then forget, and then you look at
your dives on another machine, and they LOOK COMPLETELY DIFFERENT.

That is confusing. And I guarantee that it is confusing to those
"normal users" you claim to represent.

The default units are actually ok, partly because they are so very
obvious. When you see a dive that is listed with a depth of "27 m",
there really isn't much room for confusion. You just go "oh, I wanted
feet" and go change it.

The "default dive computer" settings also probably make sense, because
that is something that might well be machine-specific (at least the
device), and it's really a convenience shorthand feature like the
default filename, not "real information". Plus again, it's not
*confusing* if you want to download dives and you have to select the
dive computer explicitly.

But look at what we do now. We have things like the tech dive settings
etc that completely change how the graph looks. And some of if is
fairly subtle indeed (gfhigh/low in particular). And we've already
seen cases where not having it in the XML file causes actual extra
noise, like when Pierre-Yves Chibon sent his xml file when he had
questions about the meaning of gfhigh/low, and in order to see his
graph, we needed to know his gfhigh/low values.

This is information that SHOULD BE IN THE XML FILE.

Putting it in the system config is wrong.

                  Linus