[PATCH] gtk-gui.c: Move the download dialog related code to a new file
Lubomir I. Ivanov
neolit123 at gmail.com
Thu Jan 10 13:18:35 PST 2013
On 10 January 2013 22:27, Amit Chaudhuri <amit.k.chaudhuri at gmail.com> wrote:
> I've been looking at the name change and code move and looking at how to
> react today.
> I was starting to think about how I could access the new device_info_list in
> order to walk through and extract the info to display in an edit nick name
> dialog. [To me] This initially implied I might need to add a function to
> return the head of the list to device.[ch] but the recent comments suggest
> moving the UI code in the other direction might make more sense.
> Now I've just read Linus' piece on the interactions with config / XML and
> Dirk's response. That seems to open up the debate on a whole new (wider)
> Fishing for comments on the best architectural approach on this.....still
> feeling my way on this a bit. Appreciate any views...
i guess it's still to be decided. but since its a new dialog, which
isn't exactly a simple "yes / no" box i would add it to a new file,
and by adding it to a new file i will also collect all nickname
related code from other files, such as the other dialog and the string
manipulation methods in gtk-gui.c. by doing so, a feature in compacted
in a properly named file (e.g. nicknames.c).
hierachically device.c is low level implementation and i don't think
the nickname code (or in fact any UI related hunks) should go in
i think gtk-gui.c has to be simplified as much as possible, so that it
only holds the base UI, like menus and some of the smaller dialogs and
core GTK stuff, so i wouldn't add anything else in there at this
point, but rather move from.
out of curiosity, how many lines of code does the patch add at this point btw?
More information about the subsurface