[PATCH] Show single dives in map.

Henrik Brautaset Aronsen subsurface at henrik.synth.no
Tue Jan 15 14:09:08 PST 2013

Lubomir I. Ivanov wrote:
> On 15 January 2013 23:45,<subsurface at henrik.synth.no>  wrote:
>> From: Henrik Brautaset Aronsen<subsurface at henrik.synth.no>
>> This adds a "Show in map" entry in the dive list context menu.  It will
>> zoom to the dive location if it exists, otherwise the full map will be
>> displayed.
>> I've also switched map tiles from OpenStreetMap to Google Maps just to
>> show off that we can.
> these patches are definitely an improvement.


> the flag doesn't seem to show over here:
> (subsurface.exe:5508): Gdk-CRITICAL **: gdk_drawable_real_draw_pixbuf: assertion
>   `src_y>= 0&&  src_y + height<= gdk_pixbuf_get_height (pixbuf)' failed

Weird.  Are you able to open flag.png in an image viewer?

> update: flag works fine on ubuntu, but not on windows.

Aha!  It might have something to do with the path?

> also there is some whitespace near:
> "   and OSM_GPS_MAP_SOURCE_VIRTUAL_EARTH_SATELLITE. We should make more of"

That was intended, it's formatted the same way as e.g. 
divelist.h#first_leaf.  There seems to be differing standards,
some start new lines with a " * ", some with "   ".  We should probably 
try to agree on one of them :)


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.hohndel.org/pipermail/subsurface/attachments/20130115/f74e5d3c/attachment.html>

More information about the subsurface mailing list