[PATCH] Show single dives in map.

Lubomir I. Ivanov neolit123 at gmail.com
Tue Jan 15 14:22:38 PST 2013


On 16 January 2013 00:09, Henrik Brautaset Aronsen
<subsurface at henrik.synth.no> wrote:
> Lubomir I. Ivanov wrote:
>
> On 15 January 2013 23:45,  <subsurface at henrik.synth.no> wrote:
>
> From: Henrik Brautaset Aronsen <subsurface at henrik.synth.no>
>
> This adds a "Show in map" entry in the dive list context menu.  It will
> zoom to the dive location if it exists, otherwise the full map will be
> displayed.
>
> I've also switched map tiles from OpenStreetMap to Google Maps just to
> show off that we can.
>
> these patches are definitely an improvement.
>
>
> Thanks.
>
>
> the flag doesn't seem to show over here:
> (subsurface.exe:5508): Gdk-CRITICAL **: gdk_drawable_real_draw_pixbuf:
> assertion
>  `src_y >= 0 && src_y + height <= gdk_pixbuf_get_height (pixbuf)' failed
>
>
> Weird.  Are you able to open flag.png in an image viewer?
>
>
> update: flag works fine on ubuntu, but not on windows.
>
>
> Aha!  It might have something to do with the path?
>

the file is definitely found by subsurface and also can be opened in
an image viewer.
can't really say what the exact cause is, though. :\

>
> also there is some whitespace near:
> "   and OSM_GPS_MAP_SOURCE_VIRTUAL_EARTH_SATELLITE. We should make more of"
>
>
> That was intended, it's formatted the same way as e.g.
> divelist.h#first_leaf.  There seems to be differing standards,
> some start new lines with a " * ", some with "   ".  We should probably try
> to agree on one of them :)
>

the warning came from "git am". there is a single space after "more of".

lubomir
--


More information about the subsurface mailing list