[PATCH] libdivecomputer: add air temperature fixups for Suunto

Dirk Hohndel dirk at hohndel.org
Tue Jan 22 20:18:28 PST 2013


Linus Torvalds <torvalds at linux-foundation.org> writes:
>
> This is not pretty, but it's *tiny* and it works. I don't know how common 
> this "air temperature in first sample" might be, and maybe it's only 
> Suunto that does this, but if we think that vendor-specific fixups for 
> these kinds of things are acceptable, at least it's simple.
>
> I'm not going to push this patch very hard, though. Because it *is* a 
> hack. 

It is actually something that I intend to do increasingly. Where we know
things that are special cases, we should extract that data and correctly
report it. We already recognize a few special cases and I am comfortable
adding more of those.

I am asking Jef to be more open to exposing details like this in the new
libdivecomputer API...

So this (and your other patches) has just been pushed.

/D


More information about the subsurface mailing list