[PATCH 1/2] Save all dive computer nicknames - whether used or not

Linus Torvalds torvalds at linux-foundation.org
Thu Jan 24 13:50:51 PST 2013

On Thu, Jan 24, 2013 at 1:32 PM, Dirk Hohndel <dirk at hohndel.org> wrote:
> Interesting. I hadn't caught on to the fact that you take the first
> entry that you see for a specific model/deviceid, not the last one that
> you see. Yes, then this works just fine.

So honestly, I haven't really decided which way is the right one.
Either "first or last" would work, the only thing it changes is
whether you'd need to load the special divecomputer xml file first or

Right now, when we load the XML file, we only set the
serial/firmware/nickname information if it wasn't already set. So the
first one is the one that sticks.

But I could imagine that we'd want to do the other way around if we
ever want to have a "load/save settings from/to XML file" graphical
interface, for example. Then it would make more sense to have the
newly loaded XML file take precedence.

But that wouldn't change the suggested multi-xml-file model much. It
would just mean that you'd put "divecomputers.xml" last on the command
line instead of first.


More information about the subsurface mailing list