[PATCH] Centralization for Kelvin and Standardization to milliKelvin

Dirk Hohndel dirk at hohndel.org
Thu Jan 24 14:57:46 PST 2013


Jan Schubert <Jan.Schubert at GMX.li> writes:

> This centralizes all occurrences of Kelvin to dive.h and standardizes all usages to milliKelvin.

Good direction...

> Signed-off-by: Jan Schubert <Jan.Schubert at GMX.li>
> ---
>  dive.h            | 19 ++++++++++---------
>  libdivecomputer.c |  2 +-
>  parse-xml.c       |  2 +-
>  save-xml.c        |  2 +-
>  uemis.c           |  4 ++--
>  5 files changed, 15 insertions(+), 14 deletions(-)
>
> diff --git a/dive.h b/dive.h
> index fc82f5e..fb14263 100644
> --- a/dive.h
> +++ b/dive.h
> @@ -11,13 +11,14 @@
>  #include <libxml/tree.h>
>  #include <openssl/sha.h>
>  
> -#define O2_IN_AIR        209     // permille
> -#define N2_IN_AIR        781
> -#define O2_DENSITY       1429    // mg/Liter
> -#define N2_DENSITY       1251
> -#define HE_DENSITY       179
> -#define SURFACE_PRESSURE 1013    // mbar
> +#define O2_IN_AIR                209     // permille
> +#define N2_IN_AIR                781
> +#define O2_DENSITY               1429    // mg/Liter
> +#define N2_DENSITY               1251
> +#define HE_DENSITY               179
> +#define SURFACE_PRESSURE         1013    // mbar
>  #define SURFACE_PRESSURE_STRING "1013"
> +#define MILLIKELVIN              273150  // mKelvin


I am almost tempted to call this a gratuitous white space change, but I
guess it makes sense.

But the one thing I do dislike is the name MILLIKELVIN - should be ZERO_C_IN_MKELVIN

I'll apply and then change the name

/D


More information about the subsurface mailing list