[PATCH 1/2] Save all dive computer nicknames - whether used or not

Dirk Hohndel dirk at hohndel.org
Thu Jan 24 15:05:01 PST 2013


Linus Torvalds <torvalds at linux-foundation.org> writes:

> On Thu, Jan 24, 2013 at 2:49 PM, Dirk Hohndel <dirk at hohndel.org> wrote:
>>
>> ^O always closes the current file so it always guarantees that there is
>> just one file open.
>
> Hmm. If so, then it's broken. It doesn't warn about throwing away
> unsaved changed.

WHAT? It should. Let me rephrase. It did when I wrote that code as
that's one of the things that I tested for. There should be NO
difference whether you do ^W or ^O WRT saving changes.

Usually the issue is that changes aren't flagged correctly - we still
may have code paths where that doesn't happen correctly. Can you
reproduce this?

> But yeah, the only case I think *really* matters is the "multiple
> files on the command line".

Ok. I'll add it to my todo list.

/D


More information about the subsurface mailing list