Missing events?

[Henrik Brautaset Aronsen]

Linus Torvalds wrote:
> On Sun, Jan 27, 2013 at 11:03 PM, Henrik Brautaset Aronsen
> <subsurface at henrik.synth.no>  wrote:
>> I just realized that I don't see events in the dive profiles of my imported
>> Suunto HelO2 dives.  In the same dives in MacDive, I see events such as "PO2
>> warning", "Ascent warning", "Deepstop" and "Tissue warning".
>>
>> Is this intentional? They should be displayed IMHO.
>
> Grr. Dirk, this is your
>
>      if (event->flags != SAMPLE_FLAGS_BEGIN&&  event->flags != SAMPLE_FLAGS_END)
>
> check in plot_events(). It's from commit 6ad73a8f043b ("Improve logic
> handling events"), where the commit comment is
>
>      Finally, for events that define a range (so they set the beginning flag
>      and assume and end flag some time later) we no loger show the triangle but
>      assume that some other code handles visualizing them (as happens for the
>      ceiling events).
>
> but the fact is, that never happened. So now all the start/end events
> that suunto sends (deco, deep stops, PO2 warnings etc) get filtered
> out.
>
> Henrik, you can just remove or comment out the line I quoted above,
> and it should work the way you want. We'll have to figure out how to
> show ranges properly.

Yup, that works.  Thanks.

As a side note, now that there is so much info in the mouseover box, the 
actual warning label is difficult to see.  Maybe we should put it in 
bold or something?

Henrik
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.hohndel.org/pipermail/subsurface/attachments/20130128/b5eddbc8/attachment.html>