[PATCH 3/3] Compile subsurface with gtk3
Jan Schubert
Jan.Schubert at GMX.li
Mon Jan 28 14:05:29 PST 2013
On 01/28/13 01:54, Linus Torvalds wrote:
> From: Linus Torvalds <torvalds at linux-foundation.org>
> Date: Sun, 27 Jan 2013 16:40:01 -0800
> Subject: [PATCH 3/3] Compile subsurface with gtk3
>
> This makes us use gtk3. There's two #if's in the source code, and
> there's the Makefile changes, both now hard-coded to gtk3. But if you
> edit the Makefile to not have the -DCOMPILE_FOR_GTK3 and to look up the
> gtk-2 libraries and include files, it uses the gtk2 code.
Thx Linus, I just gave it a try using the most current git and just
applying the Makefile changes. I had to manually patch this:
/usr/src/subsurface/info.c:652: undefined reference to `show_gps_location'
But beside this it seems to work. The differences are not as impressive
as imagined by me. One thing which one has to look twice to is the
different handling of the info window when it gets to small (which also
applies to the profile window as well when enlarging the info window).
From my humble point of view there is no need to hurry up with
switching to GTK3. Would be nice to have a more easy way than editing
the Makefile on several places to switch between GTK2 and GTK3 once
there is official support for it.
Just my EUR 0,02,
Jan
More information about the subsurface
mailing list