[PATCH] Rewrite gtk dive selection tracking logic

Henrik Brautaset Aronsen subsurface at henrik.synth.no
Mon Jan 28 23:58:46 PST 2013

Linus Torvalds wrote:
> From: Linus Torvalds<torvalds at linux-foundation.org>
> Date: Mon, 28 Jan 2013 22:22:31 -0800
> Subject: [PATCH] Rewrite gtk dive selection tracking logic
> We used to generate a list of possibly changed selections using the gtk
> tree selection "selection function".
> But that's actually meant to just tell gtk whether an entry can be
> selected or not, and our list of possibly changed entries ended up being
> stale if the selection change was due to a list entry removal, for
> example.
> So rip out the old model entirely, and instead just walk the whole
> selection that gtk gives us on a selection "change" event.  We throw all
> our old selections away when this happens, and just rebuild it all.
> This should fix the occasional internal gtklib-quartz assertion that
> Henrik is seeing.  And it actually simplifies the code too.

This commit breaks things for me.  I cannot move up/down the dive list 
with the arrow keys.  Also, the dive profile doesn't update when I 
select new dives, it stays on the first profile regardless.


More information about the subsurface mailing list