[PATCH] When switching sort order, scroll the dive list to the current dive

Dirk Hohndel dirk at hohndel.org
Thu Jan 31 15:53:52 PST 2013


Linus Torvalds <torvalds at linux-foundation.org> writes:
> NOTE! I'm not 100% sure this is the right thing to do - please play
> around with it.
>
> In many cases, you *are* interested primarily in the current dive, and
> when you switch sort order, you want to still see that current dive in
> the dive list. HOWEVER, it is also possible that you are switching
> sorting order in order to then select new dives ("change sort order to
> see the deepest dives"), and it is possible that we should just always
> scroll up to the top.
>
> That said, scrolling up to the top is always easy regardless, while
> finding the current dive is not necessarily so. So this conceptually
> keeps the easy thing still fairly easy, and makes the potentially
> annoying "try to find the current dive in the current sort list"
> trivial for the cases when you want it.
>
> Play with it, see if you like it, apply it or not.

I really like it and I pushed it. It seems much more intuitive this
way. And as you said, it's easy to get to the top.

/D


More information about the subsurface mailing list