Patches ( 4 )

[Tomaz Canabrava]

On Tue, Jul 16, 2013 at 11:05 PM, Linus Torvalds <
torvalds at linux-foundation.org> wrote:

>
>
> On Tue, Jul 16, 2013 at 6:26 PM, Tomaz Canabrava <tcanabrava at kde.org>
> wrote:
> > I'm a bit lazy today. So, this fixes a couple of things I found out in
> the
> > printing code and also tries to amenize the pain that it so use the Qt
> > version of subsurface right now. The best thing on this patch is the fix
> to
> > the ComboBoxes in the inline edit stuff - but it will also bug if you
> want
> > to cancel edition - no can do that for now, I'll update this with the
> > 'cancel' action tomorrow.
> >
> > branch is 'quirks', in tcanabrava/subsurface
>
> Ok, quick comments from very quick testing:
>
>  - *Much* better. This pretty much works now.
>

I live for that. <3


>
> But since I'm never happy, here's the list of issues that remain (they are
> not new to your code):
>
>  - Can we make the "This dive is being edited. Select Save or Undo when
> ready." be part of _every_ notebook tab? Or above/around them all?
>

Sure - will do.


>    Right now, if you start editing the equipment stuff, you don't actually
> get that thing at all. It's there, but it's there only in the "Dive notes"
> tab. You can switch to the dive notes to see it, but it's really not very
> obvious at all.
>

You are right, when I did the information pane I only had did the 'edit
notes' part, so this needs to be moved.


>
>  - I can edit the numbers/description by clicking on the field and
> starting to edit. Fine. But to actually get the selection choice, I have to
> double-click. So double-clicking gets me the behavior I actually *want*.
> Could we get that with just the single click?
>

I'm not sure - Since in 'Table views' the single click is used for
selection, I'm researching here to answer properly. If the answer is 'I
cant' there's always the possibility to override the single-click event and
make it behave like a double click.

 - The size of the fields are still wrong. It seems the field size comes
> from the size of the header for that field, and the first field (which has
> the "trashcan" to delete the line) isn't even draggable. So the thing looks
> like this:
>
>        [image: Inline image 1]
>
>
>
what's looking here is that you had a piece of old configuration that got
'stuck' with the wrong sizes of the columns. the garbage bin should look
the correct size ( it does on my clean config , just checked it ) while the
type and size looks smaller. I'll make them have a better size.


>
> and that garbage can field width isn't even fixable. And the others have
> to be fixed every time the program is started...
>

Every time? this shouldn't be. Can you check for me  one thing? in the
bottom of mainttab.cpp there *should* be 2 methods, one to save the
settings, one to restore the settings. just checked here and they are being
saved when the program quits and being restored.


>
> But the cylinder type selection does seem to work very well now - once you
> have dragged the fields to be the right width, and once you've
> double-clicked to get the selection choice. So this is already a huge
> improvement.
>

Thanks, I'm taking a look at the double click thing, and I already did
other-something to make you happy. You don't need to press Return/Enter two
times - one to close the popup, other to close the editor, anymore. it now
works with just one keypress.

branch is the same, tcanabrava/quirks , just commited this.

Tomaz


>
>               Linus
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.hohndel.org/pipermail/subsurface/attachments/20130717/b3606365/attachment-0001.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: field-width.png
Type: image/png
Size: 3556 bytes
Desc: not available
URL: <http://lists.hohndel.org/pipermail/subsurface/attachments/20130717/b3606365/attachment-0001.png>