Patches ( 4 )

[Tomaz Canabrava]

On Wed, Jul 17, 2013 at 4:14 PM, Tomaz Canabrava <tcanabrava at kde.org> wrote:

>
>
> On Wed, Jul 17, 2013 at 4:02 PM, Linus Torvalds <
> torvalds at linux-foundation.org> wrote:
>
>>
>>
>>
>> On Wed, Jul 17, 2013 at 10:47 AM, Tomaz Canabrava <tcanabrava at kde.org>wrote:
>>>
>>>
>>>> and that garbage can field width isn't even fixable. And the others
>>>> have to be fixed every time the program is started...
>>>>
>>>
>>> Every time? this shouldn't be. Can you check for me  one thing? in the
>>> bottom of mainttab.cpp there *should* be 2 methods, one to save the
>>> settings, one to restore the settings. just checked here and they are being
>>> saved when the program quits and being restored.
>>>
>>
>> It definitely happened every time. But it looks like we may have a
>> dependency problem, because it was fixed by "git clean -dqfx" and re-making
>> the tree.
>>
>>  However, that in turn causes
>>
>>    make: *** No rule to make target `../version.h', needed by
>> `qt-ui/about.o'.  Stop.
>>
>> which I think somebody already reported. So there does seem to be some
>> kind of problem with the dependencies. Whether these two problems are
>> related or not, who knows..
>>
>> Anyway, now it seems to have much better field widths, with the exception
>> of the garbage can icon which is still cut in half.
>>
>> And your fix to show the drop-down menu for cylinders and weights with a
>> single-click works fine for me.
>>
>> That said, there's some bad interaction with the other fields. Try this:
>>
>>  - single-clock on the cylinder type field. It becomes editable and the
>> drop-down entry becomes visible. Goodie.
>>
>>  - decide "oh, I didn't actually want to edit the type at all, just the
>> size or working pressure", so don't do anything with the type after all,
>> but instead single-click on one of the other fields.
>>
>> Oops. Now those fields are cleared.
>>
>> I suspect this isn't new behavior, it probably happened before too, but I
>> just didn't test that case.
>>
>
> This is "new and documented" behavior - not saying that they are correct,
> just saying that I didn't did the 'cancel' action yet. I'm working on those
> now. :)
>

Linus, this should now be fixed, same branch. <3
When you have time, can you check?
I also spotted a few bugs on editing:

- oxygen = clears, and doesn't save what you entered.
- helium too
- weigthsystems are always '0.0grams'

trying to fix those now.


>
>
>
>>                        Linus
>>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.hohndel.org/pipermail/subsurface/attachments/20130718/51beeb76/attachment-0001.html>