[subsurface] Proper hide/show tooltip under ProfileGraphicsView. Events are not properly handled and not custom tooltip status was stored. (#112)

Tomaz Canabrava tcanabrava at kde.org
Wed Jun 5 12:34:58 PDT 2013


Ups

This is all my fault actually,
I asked helio to join and forgot to tell him how to contribute.

Helio, can you generate a git pull request from the command line, and
do the commit with the -s specifier?

Tomaz - fighting with the new Help system for subsurf.



On Wed, Jun 5, 2013 at 4:28 PM, Henrik Brautaset Aronsen
<subsurface at henrik.synth.no> wrote:
> Hi Helio!
>
> Thanks for your contribution!  We're unable to use it as is, since we have
> rather specific guidelines on what kind of patches we accept.  The short
> version is:
>
> 1) Don't use GitHub pull requests
> 2) All patches must have a Signed-off-by:-line
> 3) The commit message should have a short one-line topic and a more verbose
> explanation underneath.
>
> See http://subsurface.hohndel.org/contributing/ for the complete
> explanation.  Please post your patch again to subsurface at hohndel.org :)
>
> Cheers,
> Henrik
>
>
> Helio Chissini de Castro wrote:
>
> ...rly handled and not custom tooltip status was stored.
>
> ________________________________
>
> You can merge this Pull Request by running
>
>   git pull https://github.com/heliocastro/subsurface master
>
> Or view, comment on, or merge it at:
>
>   https://github.com/torvalds/subsurface/pull/112
>
> Commit Summary
>
> Proper hide/show tooltip under ProfileGraphicsView. Events are not properly
> handled and not custom tooltip status was stored.
>
> File Changes
>
> M qt-ui/profilegraphics.cpp (19)
> M qt-ui/profilegraphics.h (2)
>
> Patch Links:
>
> https://github.com/torvalds/subsurface/pull/112.patch
> https://github.com/torvalds/subsurface/pull/112.diff
>
>
> _______________________________________________
> subsurface mailing list
> subsurface at hohndel.org
> http://lists.hohndel.org/cgi-bin/mailman/listinfo/subsurface
>


More information about the subsurface mailing list