pull-request: Hide/Show tooltip on mouse over view widget

Helio Chissini de Castro heliocastro at gmail.com
Fri Jun 7 16:44:51 PDT 2013


tssc tssc Tomaz :-)

Ok Dirk, thanks, I'll fixing my setting on Qt Creator as well to match the
guidelines

[]'s


On Fri, Jun 7, 2013 at 7:03 PM, Tomaz Canabrava <tcanabrava at kde.org> wrote:

> Actually, KDevelop can have that too, let me save this. =p
>
>
> On Fri, Jun 7, 2013 at 5:33 PM, Dirk Hohndel <dirk at hohndel.org> wrote:
> > On Fri, 2013-06-07 at 10:36 -0300, Helio Chissini de Castro wrote:
> >> The following changes since commit
> >> 4a047d3f62f0146d922529ae8a90a03cf9be4946:
> >>
> >>
> >>   Hide/Show tooltip on mouse over view widget (2013-06-07 10:10:14
> >> -0300)
> >>
> >>
> >> are available in the git repository at:
> >>
> >>
> >>   https://github.com/heliocastro/subsurface.git master
> >>
> >>
> >> for you to fetch changes up to
> >> 4a047d3f62f0146d922529ae8a90a03cf9be4946:
> >>
> >>
> >>   Hide/Show tooltip on mouse over view widget (2013-06-07 10:10:14
> >> -0300
> >
> > This leaves the actual tooltip text behind... so the tooltip window
> > shrinks (why not completely remove it?), but the white text with the
> > tooltip data is still seen on the profile.
> >
> > That looks... odd.
> >
> > Also, can you explain this:
> >
> > return status == EXPANDED ? true : false;
> >
> > why not simply
> >
> > return status == EXPANDED;
> >
> > ??
> >
> > Finally... whitespace. Poor Tomaz hides under the table when hears me
> > say this. Subsurface has some pretty strongly felt (and enforced)
> > whitespace rules.
> >
> > Thankfully, QtCreator is easily set up to automatically do this right
> > (apparently KDEvelop can't be set up like this or Tomaz wouldn't keep
> > sending me things with whitespace damage).
> >
> > Quick summary: indentation with tabs only. No 4 chars, please. No
> > trailing whitespace. '{' and '}' want a space around themselves while
> > '(' and ')' hug their arguments (no space). But there is a space after
> > keywords (to make it easier to tell them apart from function calls:
> >
> > if (a == b) {
> >         do(something);
> >         do(anotherthing);
> > } else {
> >         dontdo(anything);
> > }
> >
> > I'll be happy to clean things up (or to share my QtCreator settings that
> > implement most of this automatically).
> >
> > Thanks for the patch, but I'd ask you to redo, please.
> >
> > /D
> >
> > _______________________________________________
> > subsurface mailing list
> > subsurface at hohndel.org
> > http://lists.hohndel.org/cgi-bin/mailman/listinfo/subsurface
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.hohndel.org/pipermail/subsurface/attachments/20130607/85ea9ff5/attachment.html>


More information about the subsurface mailing list