[PATCH] Make a map ctrl-click toggle the selection state

Dirk Hohndel dirk at hohndel.org
Fri Jun 7 21:39:34 PDT 2013

On Fri, 2013-06-07 at 19:28 -0700, Thiago Macieira wrote:
> On sexta-feira, 7 de junho de 2013 18.29.37, Linus Torvalds wrote:
> > +       QFlags<QItemSelectionModel::SelectionFlag> flags;
> There's a typedef for this. We prefer QItemSelectionModel::SelectionFlags 
> (note the plural).

Let's take a step back please. With 'SelectionFlags' this doesn't even

qt-ui/divelistview.cpp: In member function ‘void
DiveListView::selectDive(dive*, bool, bool)’:
qt-ui/divelistview.cpp:60:70: error: no match for ‘operator=’ in ‘flags
= (toggle ? (QItemSelectionModel::SelectionFlag)8u :

So I'm taking the patch as Linus suggested and I'll wait for Thiago to
send in a fix to make it work (tm).


More information about the subsurface mailing list