Bug fixes for today

Linus Torvalds torvalds at linux-foundation.org
Thu Jun 13 12:00:43 PDT 2013

On Thu, Jun 13, 2013 at 11:41 AM, Tomaz Canabrava <tcanabrava at kde.org> wrote:
> Good - So, I'm back on the Visual Plan Editor.
> Linus, while dirk's asleep - you'd have anything that you want me to focus on?

No, if you can get that visual plan/new dive editing working, that
would be lovely.

I'll be diving in a couple of days, and try to use the Qt branch this
time (in Palau, not enough worked for me, this time around hopefully
the Qt branch is actually good enough to download dives and gps
coordinates and editing stuff).

One thing missing from a practical standpoint is multi-dive editing -
after downloading the dives of the day, I usually want to set things
like weights and wetsuit information for all of the new dives, and the
Qt branch doesn't have mult-dive editing yet. But from a priority
standpoint, I think it's better if you look at the visual plan editor.

Oh, and I tried to make the trip entry bold in the divelist, but the
obvious thing failed badly:

    diff --git a/qt-ui/models.cpp b/qt-ui/models.cpp
    index 601f2f6280ba..37f482b821fc 100644
    --- a/qt-ui/models.cpp
    +++ b/qt-ui/models.cpp
    @@ -783,6 +783,12 @@ QVariant TripItem::data(int column, int role) const
             if (role == SORT_ROLE)
                     return (qulonglong)trip->when;

    +        if (role == Qt::FontRole) {
    +                QFont font;
    +                font.setBold(true);
    +                return font;
    +        }
             if (role == Qt::DisplayRole) {
                     switch (column) {
                     case NR:

so if somebody knows what's wrong with that, holler. But it's not
really all that important, I just wanted to see how it looked..



More information about the subsurface mailing list