dive computer edit
Dirk Hohndel
dirk at hohndel.org
Tue Jun 18 00:40:02 PDT 2013
I thought I'd tackle something simple. And as it sometimes happens,
things spiraled out of control.
I just pushed my changes and have two requests:
a) can people who have used our dive computer nickname editing code
before please play with it and document all the ways in which I am
breaking existing behavior?
b) can people who actually speak C++/Qt read through my code and help me
turn this into something more reasonable?
The global dcList seems odd. I'm sure the way the classes are set up is
making poor Thiago weep quietly when he looks at the code.
So please, help me learn more about Qt programming and kindly point out
all the ways in which this code is horrid... I'm sure there are many.
On the plus side, (a) above not withstanding, this appears to do what I
wanted it to do and it appears to make the code easier to read and
understand. It adds quite a bit of functionality at (ignoring the .ui
file changes to bring back the OK/Cancel button) a net loss of LOC.
/D
More information about the subsurface
mailing list