Potential problem in Makefile for libdivecomputer

[Robert C. Helling]

On Mar 1, 2013, at 11:24 PM, Pablo Wolter wrote:

> If you do a "uname" in Mac the name of the Os is Darwin … not darwin … so I changed it to capitol D and it did run make without any issue:
> 
> Afer that it did installed libdivecomputer!!!
> 
> Sorry I don't know how to fix the Makefile and submit it but the OS check has to be case insensitive or changed to capitol D in case in Mac the output of the uname command capitalize the first letter all the time.
> 


I assume you have used git clone to get your copy of the source. After having changed the Makefile (and testing that indeed this is what you wanted to do) you simply do

git diff

which produces something like

diff --git a/Makefile b/Makefile
index 71e19f0..089ab37 100644
--- a/Makefile
+++ b/Makefile
@@ -56,7 +56,7 @@ ifeq ($(CC), i686-w64-mingw32-gcc)
        RESFILE = packaging/windows/subsurface.res
        LDFLAGS += -Wl,-subsystem,windows
        LIBWINSOCK = -lwsock32
-else ifeq ($(UNAME), darwin)
+else ifeq ($(UNAME), Darwin)
        LIBDIVECOMPUTERINCLUDES = $(shell $(PKGCONFIG) --cflags libdivecomputer)
        LIBDIVECOMPUTERARCHIVE = $(shell $(PKGCONFIG) --libs libdivecomputer)
 else

This you dump in an email to the list and then sign it off as I will do here:

Suggested-by: Pablo Wolter <pwolter at gmail.com>
Signed-off-by: Robert C. Helling <helling at atdotde.de>

Best
Robert
--                                                                              
.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oO 
Robert C. Helling     Elite Master Course Theoretical and Mathematical Physics  
                      Scientific Coordinator                                   
                      Ludwig Maximilians Universitaet Muenchen, Dept. Physik    
print "Just another   Phone: +49 89 2180-4523  Theresienstr. 39, rm. B339       
    stupid .sig\n";   http://www.atdotde.de 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.hohndel.org/pipermail/subsurface/attachments/20130301/00e046e5/attachment.html>