preparation for colour printing

Lubomir I. Ivanov neolit123 at gmail.com
Sat Mar 2 07:13:14 PST 2013


On 2 March 2013 14:24, Salvador Cuñat <salvador.cunat at gmail.com> wrote:
> On Wed, Feb 27, 2013 at 10:48:43AM -0800, Dirk Hohndel wrote:
>> Amit Chaudhuri <amit.k.chaudhuri at gmail.com> writes:
>>
>> > Hi,
>> >
>> > this patch adds a 3rd column to the media array of rgba so we now have one
>> > each for screen, b/w & colour printing.  I have defaulted to using the same
>> > colour printing & screen, but this can be altered anytime.
>> >
>> > I have checked that the application still compiles and prints.  The print
>> > out (colour option selected) shows the deco ceiling steps in pink but
>> > everything else appears grey scale.  Further work will be required to apply
>> > the colours to the print out, although I'm not yet sure what that involves.
>>
>> I just pushed this patch out. What it is missing is hooking things up in
>> print.c. Right now we simply set gc.printer to 1 there, instead we need
>> to be able to chose 1 or 2, depending on whether the user wants bw or
>> color printing.
>>
>

this works for me salvador,
and the print looks nice.

my only suggestion would be to have the text in the print dialog instead of:
"Colour printing on/off"
to be:
"Colour printing"
as the checkbox (on/off) is self explanatory.

shouldn't the title of the section be simply "Colours" instead of
"Colour selection"?
but also in the docs we are using "Color" instead of "Colour" - i.e.
int american english, so i would change that as well.

lubomir
--


More information about the subsurface mailing list