[PATCH] Store the main window maximized state in the configuration

Dirk Hohndel dirk at hohndel.org
Sun Mar 3 11:26:16 PST 2013


"Lubomir I. Ivanov" <neolit123 at gmail.com> writes:

> On 3 March 2013 17:56, Dirk Hohndel <dirk at hohndel.org> wrote:
>>
>> The behavior with this patch seems a bit odd...
>>
>> First time I started after compiling the window was maximized (and it
>> certainly wasn't the last time I ran Subsurface before).
>
> is_maximized is -1 when the param is not yet set.
>
>>
>> And when exiting with the window maximized then un-maximizing the window
>> gets me an odd two pane display with no divelist.
>>
>> Is that "as intended"? I think the position of the panes needs to be
>> stored separately for maximized and non-maximized or something.
>>
>
> yep, probably something like that has to be done...
> two naive sets of width, height, vpane, hpane parameters for
> "maximized" and "normal" states, but obviously the maximize / restore
> events has to be captured for that to work.
> that looks like another patch to me, which i cannot really make a
> solid promise about. could try to to make it happen next week.

I'll need to figure out what to do for 3.0.2

I find the feature interesting enough to want to include it - but I need
to make sure that it doesn't cause more regressions - so I may have to
remove it after all. Which I guess is ok as 3.0.2 is supposed to be a
bug fix release after all.

/D


More information about the subsurface mailing list