3.0.1 crashes on Mac OS

[Lubomir I. Ivanov]

On 3 March 2013 22:18, Krzysztof Arentowicz <karent.bug at gmail.com> wrote:
> Lets start with some good news:
>
> Yesterday I posted an announcement about Subsurface on biggest Polish
> scuba forum:
> http://forum-nuras.com/viewtopic.php?t=32002
>
> so hopefully there is/will be a significant increase in downloads from
> Poland. Doing my best to spread the word :)
>

hello, and thank you very much for the effort.
also the crash log is appreciated.

> I'm starting to receive feedback / feature requests and in two weeks,
> when I get back from my diving trip to Dahab (taadaa! I just had to
> boast a bit) I will collect it all and share with you.
>
> Now for the ugly part:
> Two people reported Subsurface crashing frequently on their machines.
> All Macs.Actually one guy reported trying  it on 3 machines and said it
> was unusable on all of them (MacPro, MacBookPro, iMac) - up to the point
> of crashing on startup. No more details unfortunately.
>
> The other one provided me with a crash report.
> He tried to plan a dive and the planner crashes when inputing gas type.
> Subsurface was out of the box, with no dives imported etc.
> Mind you that I don't have a Mac and I probably won't  be able to
> provide more details as I will be away next week.
> Yet someone more familiar with Macs might like to take a look at it.
>
> The crash report follows:
>
> Process: subsurface-bin [5144]
> Path: /Applications/Subsurface.app/Contents/MacOS/subsurface-bin
> Identifier: org.hohndel.subsurface
> Version: ??? (3.0.1)
> Code Type: X86 (Native)
> Parent Process: launchd [252]
>
> Date/Time: 2013-03-03 18:11:51.375 +0100
> OS Version: Mac OS X 10.6.8 (10K549)
> Report Version: 6
>
> Interval Since Last Report: 7896334 sec
> Crashes Since Last Report: 72
> Per-App Interval Since Last Report: 1455 sec
> Per-App Crashes Since Last Report: 3
> Anonymous UUID: 9A3D5A7A-2FF7-40AD-B33D-6D1EDB919C30
>
> Exception Type: EXC_CRASH (SIGABRT)
> Exception Codes: 0x0000000000000000, 0x0000000000000000
> Crashed Thread: 0 Dispatch queue: com.apple.main-thread
>
> Application Specific Information:
> __abort() called
>
> Thread 0 Crashed: Dispatch queue: com.apple.main-thread
> 0 libSystem.B.dylib 0x94da5c5a __kill + 10
> 1 libSystem.B.dylib 0x94da5c4c kill$UNIX2003 + 32
> 2 libSystem.B.dylib 0x94e385a5 raise + 26
> 3 libSystem.B.dylib 0x94e4e679 __abort + 124
> 4 libSystem.B.dylib 0x94e31334 release_file_streams_for_task + 0
> 5 subsurface-bin 0x0001eae6 size_data_func + 306

this SYGABRT could be a buffer overflow in equipment.c:size_data_func().
triggered when convert_volume_pressure() sets "size" to 0.0.

looking at the translation for the shortened word "unkn" in polish:

#: equipment.c:1346 equipment.c:1366
msgid "unkn"
msgstr "nie podano"

"nie podano" is 10 characters, excluding the null terminating character.

i've sent a patch which may solve the issue, if that's the case:
hopefully someone on a mac will test this out.

lubomir
--