Bug switching views
Robert C. Helling
helling at lmu.de
Mon Mar 4 00:15:46 PST 2013
On Sun, 3 Mar 2013, Dirk Hohndel wrote:
> "Robert C. Helling" <helling at atdotde.de> writes:
Dirk,
> I decided to tackle this one myself.
thanks. After yesterday's patch, I had not been able to reproduce
Sergey's problem anymore but if this mornings message would have been that
it is persistent I would have implemented a similar thing with a global
variable to indicate THREE_VIEW.
That said, I can confirm that this seems to work for me (but so did my
last version ;-)). There is just one comment: Why don't you do the testing
if (pane_conf == PANE_THREE)
in list_view() and the other two and not in save_pane_position()? There it
would replace my if()'s testing against window geometry. This would
eliminate some code duplication and, more importantly,
save_pane_position() is also called from save_window_geometry() whose
calling pattern is not obvious to me but I guess is it is called on quit
at least. So, theoretically, we could still have the situation where the
pane position is saved upon exit if we are not in PANE_THREE.
Here is a patch to show what I mean.
Signed-off-by: Robert C. Helling <helling at atdotde.de>
Robert
--
.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oO
Robert C. Helling Elite Master Course Theoretical and Mathematical Physics
Scientific Coordinator
Ludwig Maximilians Universitaet Muenchen, Dept. Physik
print "Just another Phone: +49 89 2180-4523 Theresienstr. 39, rm. B339
stupid .sig\n"; http://www.atdotde.de
-------------- next part --------------
A non-text attachment was scrubbed...
Name: pane_test_moved.patch
Type: text/x-diff
Size: 1689 bytes
Desc:
URL: <http://lists.hohndel.org/pipermail/subsurface/attachments/20130304/568857e3/attachment-0001.patch>
More information about the subsurface
mailing list