Bug switching views

[Dirk Hohndel]

"Robert C. Helling" <helling at lmu.de> writes:

> On Sun, 3 Mar 2013, Dirk Hohndel wrote:
>
>> "Robert C. Helling" <helling at atdotde.de> writes:
>
> Dirk,
>
>> I decided to tackle this one myself.
>
> thanks. After yesterday's patch, I had not been able to reproduce 
> Sergey's problem anymore but if this mornings message would have been that 
> it is persistent I would have implemented a similar thing with a global 
> variable to indicate THREE_VIEW.
>
> That said, I can confirm that this seems to work for me (but so did my 
> last version ;-)). There is just one comment: Why don't you do the testing
>
> if (pane_conf == PANE_THREE)
>
> in list_view() and the other two and not in save_pane_position()? There it 
> would replace my if()'s testing against window geometry. 

I didn't know if those might come in handy in other situations...

> This would eliminate some code duplication and, more importantly,
> save_pane_position() is also called from save_window_geometry() whose
> calling pattern is not obvious to me but I guess is it is called on
> quit at least. So, theoretically, we could still have the situation
> where the pane position is saved upon exit if we are not in
> PANE_THREE.

Ok, that makes sense.

> Here is a patch to show what I mean.

I'll take that and recreate the binaries / sources - the save on exit
thing makes a difference :-(

/D