Non-libdivecomputer events

Linus Torvalds torvalds at linux-foundation.org
Thu Mar 7 07:59:03 PST 2013


On Thu, Mar 7, 2013 at 7:52 AM, Dirk Hohndel <dirk at hohndel.org> wrote:
>
>
> I guess libdivecomputer could pick ONE value that it defines as "SAMPLE_EVENT_NOTUSED". But even that isn't really necessary. All we need to do is add another member to our structure and if that member is non-NULL ignore the libdc event number and use that number instead.

Please don't even bother. The numbers are idiotic. They are completely
meaningless, and we - for very good reasons - don't even use them.

Just describe the event in a string. It's that simple. We actually use
the strings, and there are tons of reasons why text is better than
idiotic binary formats. And "opaque number" is very much a binary
format, even if you were to save it as text.

Data has to be *meaningful* in order to be processed. Random numbers
are not meaningful.

              Linus


More information about the subsurface mailing list