[RFC PATCH] Warn about commas in floating point values?

Miika Turkia miika.turkia at gmail.com
Thu Mar 7 20:19:42 PST 2013


On Fri, Mar 8, 2013 at 6:07 AM, Dirk Hohndel <dirk at hohndel.org> wrote:
>
> On Mar 7, 2013, at 7:55 PM, Miika Turkia wrote:
>>>> The comma will the the *norm* for anything that gets translated with
>>>> xslt in a locale that just prints them out that way.
>>>>
>>>> Right now Miika goes to insane lengths to format things with a decimal
>>>> point. All of that is just wasted effort. And we can't warn about the
>>>> commas, because it would warn for perfectly fine data.
>>>
>>> Got it. OK.
>>>
>>> I'll take your fragment, add your SOB, figure out how we track that this
>>> is a Subsurface native file and make all of this magically work as
>>> intended :-)
>>
>> I could e.g. change the program attribute of the produced XML to
>> subsurface-import. There is no point in "lying" about the format if
>> there is a difference in parsing subsurface produced files versus XSLT
>> mangled files.
>
> Yes - subsurface-import is a good way to mark them.
>
> And you can revert all the changes where you transform commas into periods.

I suspect the Windows locale induced format-number fix can also go,
but that should be tested before ripping it off. So I'll start the XSL
exercise only after you have a Windows installer with the change
included available somewhere.

miika


More information about the subsurface mailing list