Choosing map providers problem

[Henrik Brautaset Aronsen]

Dirk Hohndel wrote:
> "Robert C. Helling"<helling at lmu.de>  writes:
>
>> Restarting subsurface seems to help. But still, I get an empty map with
>> google satellite and only the lineart with google hybrid, anything with
>> Yahoo only gives me the OSM map.
>>
>> Maybe we should restrict the options to stuff that works?
>
> Thanks - I never thought of that.
>
> Strangely this all worked fine for me (actually, two maps didn't, so I
> disabled them).
>
> Can we get more data from other testers? Is this a geo-regional issue (I
> was actually worried about that)? Is this an API key issue?

These are the one that works (or not) for me here from Norway:

OpenStreetMap I - works
OpenStreetMap II - blank map (Cannot resolve hostname tah.openstreetmap.org)
OpenAerialMap - works (looks like OpenStreetMap I)
MapsForFree - works
OpenCycleMap - blank map (Probably not relevant for diving either)
Public Transport - works (But possibly not relevant?)
Google Maps - works
Google Satellite - blank map
Google Hybrid - works (but without sat data)
Virtual Earth - works
Virtual Earth Satellite - works
Virtual Earth Hybrid - works
Yahoo Maps - works
Yahoo Satellite - works (but looks like Yahoo Maps)
Yahoo Hybrid - works (but looks like Yahoo Maps)
OSMC Trails - blank map (Cannot resolve hostname topo.geofabrik.de)

The last three weren't saved when selected in the preferences.  I had to 
apply the following:

--- a/gtk-gui.c
+++ b/gtk-gui.c
@@ -1010,7 +1010,8 @@ static void preferences_dialog(GtkWidget *w, 
gpointer data)
  #else
                 char *provider = 
gtk_combo_box_get_active_text(GTK_COMBO_BOX(map_provider));
  #endif
-               for (i = OSM_GPS_MAP_SOURCE_OPENSTREETMAP; i <= 
OSM_GPS_MAP_SOURCE_YAHOO_STREET; i++)
+               for (i = OSM_GPS_MAP_SOURCE_OPENSTREETMAP; i <= 
OSM_GPS_MAP_SOURCE_LAST; i++)
                         if 
(!strcmp(provider,osm_gps_map_source_get_friendly_name(i))) {
                                 prefs.map_provider = i;
                                 break;

Anyway, they didn't work properly anyway.

I propose to disable the blank and irrelevant maps.  Should I prepare a 
patch?

Henrik
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.hohndel.org/pipermail/subsurface/attachments/20130314/51e56328/attachment.html>