[PATCH] Fix bug in colour print initialisation.

amit.k.chaudhuri at gmail.com amit.k.chaudhuri at gmail.com
Thu Mar 14 10:54:06 PDT 2013


From: Amit Chaudhuri <amit.k.chaudhuri at gmail.com>

The callback function for switching colour printing on/off was
registered after the initial activation of the button. This meant the
first attempt to print was compromised. We move the registration so that
printing works as the user specifies from the first attempt.

Tested by printing both B/W and colour images to file with minimal mouse
clicks.

Spotted by Salva - thanks.

Signed-off-by: Amit Chaudhuri <amit.k.chaudhuri at gmail.com>
---
 print.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/print.c b/print.c
index a015a4e..9ea0978 100644
--- a/print.c
+++ b/print.c
@@ -924,10 +924,10 @@ static GtkWidget *print_dialog(GtkPrintOperation *operation, gpointer user_data)
 			G_CALLBACK(print_selection_toggle), NULL);
 		GtkWidget *colorButton;
 		colorButton = gtk_check_button_new_with_label(_("Print in color"));
-		gtk_toggle_button_set_active(GTK_TOGGLE_BUTTON(colorButton),TRUE);
-		gtk_box_pack_start(GTK_BOX(box), colorButton, FALSE, FALSE, 2);
 		g_signal_connect(G_OBJECT(colorButton), "toggled",
 			G_CALLBACK(color_selection_toggle), NULL);
+		gtk_toggle_button_set_active(GTK_TOGGLE_BUTTON(colorButton),TRUE);
+		gtk_box_pack_start(GTK_BOX(box), colorButton, FALSE, FALSE, 2);
 	}
 
 	gtk_widget_show_all(vbox);
-- 
1.7.10.4



More information about the subsurface mailing list