Invalid dives

[Ďoďo]

Dirk,

you are right in terms of multi-valued dive type. But I would not mix a
dive type (ice, shore, boat, training) with the dives which should be
ignored/hidden. All of them can be internally represented with let's say
one integer (32-bit, is it enough? 1 bit for one type, they can be of
course combined, 31 types of dives 1 bit for invalid/hidden ;))

Dive type from my point of view is something, one should be able to set
withing "Edit dive" dialog. Invalid dive should be possible to tag without
going in to "Edit dive" and it should be doable for multiple dives. After 1
click they simple disappear from the dive list as they do now. Yes, one can
tag several dives as ice dives as well but I think invalid/hidden dive and
dive types should not be mixed.

BTW, name "invalid dive" was just a first shot, it can be called "hidden
dive" or whatever ....

O.K. So I will modify for me the code to use just one bit for the invalid
withing 32bit a send the correct version of 'git diff'. It is my first
usage of git so sorry for the previous reverse version

Jozef




On Sun, Mar 17, 2013 at 5:28 PM, Dirk Hohndel <dirk at hohndel.org> wrote:

>
> On Mar 16, 2013, at 9:40 PM, Ďoďo wrote:
>
> > Dirk,
> >
> > because my "Invalid dives" were dives I was swimming and freediving with
> my dive computer. So I was checking how deep water was on different places.
> >
> > Another cases are during the dive courses, actually during OWD mainly.
> >
> > 1. Swimming pool: I do not count for me swimming pool lessons as a real
> dives. But I track them - yes, I am too lazy to write it on paper.
> > 2. Till you really start some dive with group of beginners it takes
> sometimes few "invalid" short dives. Again, I do not want to have them
> displayed as real dive, but I wanna keep them.
> >
> > is it enough?
>
> I understand that you want them to be a special type of dives that you can
> somehow exclude. I'm not sure why you'd want to keep them, but of course
> "the user is always right".
>
> This of course opens a huge can of worms. How are these dives treated in
> statistics? How are they handled when it comes to dive numbering? What
> happens if a dive is tagged as "invalid" (why "invalid", btw? Shouldn't
> that be "ignored"?) and then re-downloaded / re-imported from a different
> source (say you are like me and dive with four or five dive computers)?
>
> This adds a lot more questions than your first implementation addressed.
>
> > I did not use boolean - I did consider - because SHORT allows to
> distinguish between different type of invalid dives - if once needed.
>
> I actually agree with that. If we really want to go that route than this
> should be just a dive type that is multi-valued. We could basically add an
> arbitrary number of tags to a dive. Things like "shore", "boat", "ice",
> "training", "ignored" and then have a UI that allows you to pick and choose
> which tags you want to exclude or include… that seems much more useful.
>
> /D
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.hohndel.org/pipermail/subsurface/attachments/20130318/c15cc7d1/attachment.html>