[PATCH] Make relative times default in planner.

Robert C. Helling helling at atdotde.de
Sat Mar 23 08:30:26 PDT 2013


On Mar 23, 2013, at 3:08 PM, Lubomir I. Ivanov wrote:

> - i don't think a forwarded patch will apply using "git am" without
> removing the quoted lines (>) first.

That was my first go at git prepare-patch. I failed sending it from mail program on my mac.

> - not sure if due to the forward, but the patch has leading spaces
> instead of tabs

Bugger. That should now be better (after using a combination of Aquamacs which does not use the settings in .emacs for some reason) and vi (to insert proper spaces).

> - perhaps it will better to have this:
> 
>>>      }
>>> +     else {
>>> +             if(*text == '@') {
> 
> formed as:
> 
> } else if (*text == '@') {
> 
> }
> 
> since there is only one "if" statement inside the "else" branch.
> 

OK.

> - please correct me if i'm wrong, but shouldn't there also be a
> modification in starttime_focus_out_cb(), where the "is_rel" flag has
> to be taken into account for this to work?


I don't get what you are aiming at here.

Best
Robert

--                                                                              
.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oO 
Robert C. Helling     Elite Master Course Theoretical and Mathematical Physics  
                      Scientific Coordinator                                   
                      Ludwig Maximilians Universitaet Muenchen, Dept. Physik    
print "Just another   Phone: +49 89 2180-4523  Theresienstr. 39, rm. B339       
    stupid .sig\n";   http://www.atdotde.de 



More information about the subsurface mailing list