[PATCH] Fix crash on right click dive trip.
Dirk Hohndel
dirk at hohndel.org
Wed May 8 11:12:38 PDT 2013
On Wed, 2013-05-08 at 20:09 +0200, Henrik Brautaset Aronsen wrote:
>
> Den 8. mai 2013 19:35 skrev "Tomaz Canabrava" <tcanabrava at kde.org>
> følgende:
> >
> > why not a if (!d) return; ?
> > this way you don't need the second if to try too things, and the
> patch will be smaller.
>
> I thought so as well in "[PATCH] Fix crash when pressing down arrow at
> the end of the dive list", but apparently it was the wrong thing to
> do.
>
> I'm not entirely convinced :)
Look at what I pushed to the Qt branch a little while ago.
That was the correct solution, I believe.
/D
More information about the subsurface
mailing list