Qt branch updates

[Tomaz Canabrava]

Dirk,

I looked at the code on the Web ( no computer to try them now, traveling
around )

Just 2 notes:
1- QItemSelection selection; instead of = QItemSelection(); there's no need
to equal a new object with another if what you want is a stack allocated
memory ( on the heap you need a 'new' or malloc)

2 - the code from up arrow, down arrow and selection logic looks like a lot
of duplicated code - can't that be handled my some helpers?

T
Em 12/05/2013 12:17, "Henrik Brautaset Aronsen" <subsurface at henrik.synth.no>
escreveu:

> Dirk Hohndel wrote:
>
> On Sun, 2013-05-12 at 16:53 +0200, Salvador Cuñat wrote:
>
> On Sun, May 12, 2013 at 07:12:40AM -0700, Dirk Hohndel wrote:
>
> Which brings me back to my earlier two requests - now with actual code
> to test in the git tree:
>
> Subsurface users - test that the selection seems right.
>
>
> Working fine now.
>
> What still puzzles me is that the selected dive is always centered in
> the view and the whole list scrolls up and down.  But I understand this
> is a design feature.
>
>
> Well, it's something that I did because I felt it looked "right".
> Can you describe a better design?
>
>
> Scroll when you get to the top or bottom of the list.  Not whole-page
> scrolls like in the Gtk version, just one line at a time.
>
> Henrik
>
> _______________________________________________
> subsurface mailing list
> subsurface at hohndel.org
> http://lists.hohndel.org/cgi-bin/mailman/listinfo/subsurface
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.hohndel.org/pipermail/subsurface/attachments/20130512/9c872ae9/attachment-0001.html>