[PATCH] Capitalize package name and add capitalized tar-ball prefix (was: [PATCH 8/8] A release includes a tar-ball.)

Cristian Ionescu-Idbohrn cristian.ionescu-idbohrn at axis.com
Sun May 12 09:34:32 PDT 2013


On Sun, 12 May 2013, Dirk Hohndel wrote:
> On Sun, 2013-05-12 at 17:07 +0200, Cristian Ionescu-Idbohrn wrote:
> > On Sun, 12 May 2013, Cristian Ionescu-Idbohrn wrote:
> > > On Sun, 12 May 2013, Dirk Hohndel wrote:
> > > > On Sun, 2013-05-12 at 14:56 +0200, Cristian Ionescu-Idbohrn wrote:
> > > > >
> > > > > New patches comming up shortly.
> > > >
> > > > Thanks, the rest looked good!
> > >
> > > Great, though...
> > >
> > > Looking closely through the README, I notice you seem to prefer
> > > capitalized package name, both for the tar-ball name and also for the
> > > tar-ball topdir name.  Do you want to keep that way or is it ok to simply
> > > have it lower case?
> > >
> > > I missed the `git archive' '--prefix' option.  I'll send a patch to
> > > correct that.  Same casing question (as above) applies.
> >
> > Yes, and one more thing: the tar-ball extension (.tgz vs. .tar.gz).  What
> > do you prefer?
>
> tgz
>
> see http://subsurface.hohndel.org/downloads

Not that I fully understand capitalization, but here you go:

Signed-off-by: Cristian Ionescu-Idbohrn <cristian.ionescu-idbohrn at axis.com>
---
 Makefile |    8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/Makefile b/Makefile
index 7ff9a6e..4474629 100644
--- a/Makefile
+++ b/Makefile
@@ -20,6 +20,10 @@ XSLTDIR = $(DATADIR)/subsurface/xslt
 gtk_update_icon_cache = gtk-update-icon-cache -f -t $(ICONPATH)

 NAME = subsurface
+CAPITALIZED_NAME = $(shell	_name=$(NAME); \
+				_rest=$${_name\#?}; \
+				_1st=$$(echo $${_name%$$_rest} | tr a-z A-Z); \
+				echo $$_1st$$_rest)
 ICONFILE = $(NAME)-icon.svg
 DESKTOPFILE = $(NAME).desktop
 MANFILES = $(NAME).1
@@ -315,6 +319,8 @@ clean:

 release:
 	@scripts/check-version -cr $(VERSION_STRING)
-	git archive -o $(NAME)-$(VERSION_STRING).tar.gz v$(VERSION_STRING)
+	git archive --prefix $(CAPITALIZED_NAME)-$(VERSION_STRING)/ \
+		--output $(CAPITALIZED_NAME)-$(VERSION_STRING).tgz \
+		v$(VERSION_STRING)

 -include $(DEPS)
-- 
1.7.10.4


More information about the subsurface mailing list